feat: Updating the active states for chips + bgTertiary Light Mode#585
Open
chrislkaufman wants to merge 10 commits into
Open
feat: Updating the active states for chips + bgTertiary Light Mode#585chrislkaufman wants to merge 10 commits into
chrislkaufman wants to merge 10 commits into
Conversation
…ead of bgInverse. Also updated bgTertiary dark mode value to use gray30
Collaborator
✅ Heimdall Review Status
✅
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
✅
1/1
|
Denominator calculation
|
Resolve changelog and package.json version conflicts: keep 8.65.0 and interleave upstream 8.64.x entries. Made-with: Cursor
chrislkaufman
temporarily deployed
to
production
GitHub Actions
Inactive
chrislkaufman
temporarily deployed
to
production
GitHub Actions
Inactive
hcopp
reviewed
Apr 15, 2026
| accessibilityState={{ selected: isActive }} | ||
| invertColorScheme={isActive} | ||
| background={isActive ? 'bgTertiary' : 'bgSecondary'} | ||
| invertColorScheme={false} |
Contributor
There was a problem hiding this comment.
Can you ask Cursor to "remove invertColorScheme={false} (and double check that it is safe to do so)"? Looks good to me to remove
hcopp
reviewed
Apr 15, 2026
| children = value, | ||
| accessibilityLabel = typeof children === 'string' ? `Remove ${children}` : 'Remove option', | ||
| invertColorScheme = true, | ||
| invertColorScheme = false, |
Contributor
There was a problem hiding this comment.
nit: can you ask Cursor to "drop the destructuring of this invertColorScheme prop"
hcopp
reviewed
Apr 15, 2026
| ) | ||
| } | ||
| inverted={active} | ||
| inverted={false} |
Contributor
There was a problem hiding this comment.
Can you also remove this inverted? It defaults to false for MediaChip so we don't need to explicitly set it to false.
hcopp
reviewed
Apr 15, 2026
| accessibilityState={{ selected: isActive }} | ||
| inverted={isActive} | ||
| background={isActive ? 'bgTertiary' : 'bgSecondary'} | ||
| inverted={false} |
hcopp
reviewed
Apr 15, 2026
| aria-selected={isActive} | ||
| invertColorScheme={isActive} | ||
| background={isActive ? 'bgTertiary' : 'bgSecondary'} | ||
| invertColorScheme={false} |
Contributor
There was a problem hiding this comment.
Lets ask Cursor to "check this in all places, including removing the destructuring invertColorScheme" where no longer necessary.
Resolve version conflicts: bump @coinbase/cds-web, cds-mobile, cds-common, and cds-mcp-server to 8.67.0 with combined changelog (upstream 8.66.x history + chip active-state release notes). Made-with: Cursor
chrislkaufman
temporarily deployed
to
production
GitHub Actions
Inactive
chrislkaufman
temporarily deployed
to
production
GitHub Actions
Inactive
Contributor
|
Here are the mobile screenshots
|
…angelog Made-with: Cursor
chrislkaufman
temporarily deployed
to
production
GitHub Actions
Inactive
chrislkaufman
temporarily deployed
to
production
GitHub Actions
Inactive
chrislkaufman
temporarily deployed
to
production
GitHub Actions
Inactive
chrislkaufman
temporarily deployed
to
production
GitHub Actions
Inactive
sverg-cb
approved these changes
Apr 22, 2026
Contributor
sverg-cb
left a comment
sverg-cb
left a comment
There was a problem hiding this comment.
nice nice, looks good to me 🚀
Collaborator
|
Review Error for sverg-cb @ 2026-04-22 16:32:49 UTC |
sverg-cb
approved these changes
Apr 22, 2026
sverg-cb
approved these changes
Apr 22, 2026
Collaborator
|
Review Error for sverg-cb @ 2026-04-22 16:36:10 UTC |
sverg-cb
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Request from Andy Montgomery to change the active state of chips because they were too visually heavy in the UI. So, the active state was updated to bgTertiary instead of bgInverse. Additionally, the bgTertiary dark mode value was updated to gray 30 instead of gray 20.
This change is only for the defaultTheme and coinbaseTheme.
Root cause (required for bugfixes)
UI changes
Testing
How has it been tested?
Testing instructions
Try clicking on select chip or tabbed chip to see the value change
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false